Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDBStore: Add missing delete for _inc_set_handle #15512

Merged
merged 1 commit into from
May 21, 2024
Merged

TDBStore: Add missing delete for _inc_set_handle #15512

merged 1 commit into from
May 21, 2024

Conversation

mattgbio
Copy link
Contributor

@mattgbio mattgbio commented May 3, 2024 •
edited
Loading

Summary of changes

A missing delete in the TDBStore has been added to the deinit() function. The required delete of _inc_set_handle is included in the init() function in case of an error (line 1147), but it is missing in the deinit() function.

Contribution is provided on behalf of BIOTRONIK.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 0xc0170 changed the title Added missing delete TDBStore: Add missing delete for _inc_set_handle May 3, 2024
@0xc0170
Copy link
Contributor

0xc0170 commented May 6, 2024

CI started

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label May 6, 2024
@mbed-ci
Copy link

mbed-ci commented May 6, 2024

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels May 6, 2024
@0xc0170 0xc0170 merged commit e04a55f into ARMmbed:master May 21, 2024
18 of 20 checks passed
@mergify mergify bot removed the ready for merge label May 21, 2024
@multiplemonomials multiplemonomials mentioned this pull request Jul 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattgbio @0xc0170 @mbed-ci